-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 06/15/2010 03:32 PM, Māris Fogels wrote: > Review: Approve > Hi Aaron, > > The code looks good. I assume there are no pagetests for this?
I have found and updated the pagetests.
> I am surprised we do not already have a basic test helper like the one you coded. Is there a duplicate helper, or just a lot of code duplication?
Neither, really. Testing page contents with unit tests has not really been done until recently, so there was no need for it.
Aaron -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkwX2uwACgkQ0F+nu1YWqI2xHgCfdGd3EyLTcIg+bZnwInHvmREM 2fMAn08QDNElbTMvpYjA/d3LIotXjm+2 =5QsF -----END PGP SIGNATURE-----
« Back to merge proposal
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/15/2010 03:32 PM, Māris Fogels wrote:
> Review: Approve
> Hi Aaron,
>
> The code looks good. I assume there are no pagetests for this?
I have found and updated the pagetests.
> I am surprised we do not already have a basic test helper like the one you coded. Is there a duplicate helper, or just a lot of code duplication?
Neither, really. Testing page contents with unit tests has not really
been done until recently, so there was no need for it.
Aaron enigmail. mozdev. org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkw X2uwACgkQ0F+ nu1YWqI2xHgCfdG d3EyLTcIg+ bZnwInHvmREM vpYjA/d3LIotXjm +2
2fMAn08QDNElbTM
=5QsF
-----END PGP SIGNATURE-----