Merge lp://staging/~abentley/launchpad/non-product-branches into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Māris Fogels |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11021 |
| Proposed branch: | lp://staging/~abentley/launchpad/non-product-branches |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
180 lines (+47/-29) 6 files modified
lib/lp/code/browser/sourcepackagerecipelisting.py (+1/-7) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+0/-5) lib/lp/code/browser/tests/test_sourcepackagerecipelisting.py (+33/-0) lib/lp/code/stories/sourcepackagerecipes/xx-recipe-listings.txt (+6/-11) lib/lp/code/templates/sourcepackagerecipe-listing.pt (+0/-6) lib/lp/testing/__init__.py (+7/-0) |
| To merge this branch: | bzr merge lp://staging/~abentley/launchpad/non-product-branches |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Māris Fogels (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
= Summary =
Fix bug #594240: Recipe listing pages assume base branch is product branch
== Proposed fix ==
Remove product column from branch listings. It is not an essential piece of
information.
== Pre-implementation notes ==
None
== Implementation details ==
None
== Tests ==
bin/test -t TestSourcePacka
== Demo and Q/A ==
Create a recipe for a sourcepackage branch. View the recipe listings for that
branch. It should not oops.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
| Aaron Bentley (abentley) wrote | # |
Hi Aaron,
The code looks good. I assume there are no pagetests for this? (I'm sure ec2 will catch them if there are.)
I am surprised we do not already have a basic test helper like the one you coded. Is there a duplicate helper, or just a lot of code duplication?
Looks good, r=mars
Maris