Code review comment for lp://staging/~3v1n0/gtk/unity-maximized-headerbar-buttons-hide

Revision history for this message
desrt (desrt) wrote :

Should we perhaps consider integrating this into the logic in gtkwindow.c about gtk_window_set_hide_titlebar_when_maximized()? The logic here seems to be a little bit inside out with regard to registering for events on the window and then verifying with the window that we are indeed the correct titlebar for receiving these actions, when the window itself knows which one is the real titlebar...

We have a bad history of unexpected things happening when we hide widgets like this... we used to hide GtkMenuBar from dbusmenu and it broke all kinds of things... I can imagine some app code somewhere getting upset because of this.

« Back to merge proposal