GTK+

Merge lp://staging/~3v1n0/gtk/unity-maximized-headerbar-buttons-hide into lp://staging/~ubuntu-desktop/gtk/ubuntugtk3

  1. unity-maximized-headerbar-buttons-hide
  2. Merge into ubuntugtk3
Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 511
Proposed branch: lp://staging/~3v1n0/gtk/unity-maximized-headerbar-buttons-hide
Merge into: lp://staging/~ubuntu-desktop/gtk/ubuntugtk3
Prerequisite: lp://staging/~3v1n0/gtk/unity-border-radius-support
Diff against target: 162 lines (+139/-0)
3 files modified
debian/changelog (+2/-0)
debian/patches/series (+1/-0)
debian/patches/unity-headerbar-maximized-mode.patch (+136/-0)
To merge this branch: bzr merge lp://staging/~3v1n0/gtk/unity-maximized-headerbar-buttons-hide
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+288552@code.staging.launchpad.net

Commit message

debian/patches/gtk-shell-shows-window-buttons.patch:
  - Hide headerbar window buttons when a window is maximized in Unity

Description of the change

This will work once lp:~3v1n0/unity/gtk-border-radius-support lands, as it depends on the _UNITY_SHELL atom that we don't export yet.

To post a comment you must log in.
lp://staging/~3v1n0/gtk/unity-maximized-headerbar-buttons-hide updated
506. By Marco Trevisan (Treviño)

debian/patches/unity-border-radius.patch:
 - Don't draw window border in unity for any theme. Add unity-csd style class.

507. By Marco Trevisan (Treviño)

debian/patches/unity-headerbar-maximized-mode.patch:
  - Hide headerbar window buttons when a window is maximized in Unity

508. By Marco Trevisan (Treviño)

debian/patches/unity-headerbar-maximized-mode.patch: hide title label when maximized

509. By Marco Trevisan (Treviño)

Merging with lp:~3v1n0/gtk/unity-border-radius-support

510. By Marco Trevisan (Treviño)

debian/patches/unity-headerbar-maximized-mode.patch: hide title in unity when maximized

Also, set the toolbar-mode style class also when the headerbar has no window controls

511. By Marco Trevisan (Treviño)

debian/patches/unity-headerbar-maximized-mode.patch: hide label on construction if toplevel is maximized

512. By Marco Trevisan (Treviño)

debian/patches/unity-headerbar-maximized-mode.patch: only hide title if it matches with the toplevel title

513. By Marco Trevisan (Treviño)

debian/patches/unity-headerbar-maximized-mode.patch: use gtk_widget_set_visible

514. By Marco Trevisan (Treviño)

Merging with lp:~3v1n0/gtk/unity-border-radius-support

Revision history for this message
desrt (desrt) wrote :

Should we perhaps consider integrating this into the logic in gtkwindow.c about gtk_window_set_hide_titlebar_when_maximized()? The logic here seems to be a little bit inside out with regard to registering for events on the window and then verifying with the window that we are indeed the correct titlebar for receiving these actions, when the window itself knows which one is the real titlebar...

We have a bad history of unexpected things happening when we hide widgets like this... we used to hide GtkMenuBar from dbusmenu and it broke all kinds of things... I can imagine some app code somewhere getting upset because of this.

lp://staging/~3v1n0/gtk/unity-maximized-headerbar-buttons-hide updated
515. By Marco Trevisan (Treviño)

Merging with lp:~ubuntu-desktop/gtk/ubuntugtk3

516. By Marco Trevisan (Treviño)

debian/patches/unity-headerbar-maximized-mode.patch: hide titlebar if the current headerbar is the window titlebar

Revision history for this message
desrt (desrt) wrote :

This patch looks pretty good now, but as usual, I cannot ACK (nor comment on the debian/ bits).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches