Checkbox

Merge lp://staging/~zyga/checkbox/fix-1444662 into lp://staging/checkbox

  1. fix-1444662
  2. Merge into trunk
Proposed by Zygmunt Krynicki
Status: Work in progress
Proposed branch: lp://staging/~zyga/checkbox/fix-1444662
Merge into: lp://staging/checkbox
Diff against target: 148 lines (+71/-3)
4 files modified
plainbox/plainbox/impl/clitools.py (+30/-0)
plainbox/plainbox/impl/commands/inv_selftest.py (+5/-3)
plainbox/plainbox/impl/test_clitools.py (+33/-0)
plainbox/plainbox/test_provider_manager.py (+3/-0)
To merge this branch: bzr merge lp://staging/~zyga/checkbox/fix-1444662
Reviewer Review Type Date Requested Status
Po-Hsu Lin Approve
Sylvain Pineau (community) Approve
Maciej Kisielewski (community) Approve
Review via email: mp+256491@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Nice!
Tested from OSX -> ssh -> ubuntu. Nice two warnings. w00t!

review: Approve
Reply
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Perhaps we should edit the bug description to include a simple
workaround up in the top.

***WORKAROUND***
after logging in, unset LC_CTYPE with this code:
$ unset LC_CTYPE
*** WORKAROUND***

And let's try to figure out the right SSH developer to poke to filter
out the bogus value in the first place.

On Thu, Apr 16, 2015 at 6:07 PM, Maciej Kisielewski
<email address hidden> wrote:
> The proposal to merge lp:~zyga/checkbox/fix-1444662 into lp:checkbox has been updated.
>
> Status: Needs review => Approved
>
> For more details, see:
> https://code.launchpad.net/~zyga/checkbox/fix-1444662/+merge/256491
> --
> You are the owner of lp:~zyga/checkbox/fix-1444662.

Reply
Revision history for this message
Daniel Manrique (roadmr) wrote :

Setting back to "needs review" to avoid choking tarmac.

Reply
Revision history for this message
Daniel Manrique (roadmr) wrote :

Trial by fire: I'll approve this to get the tarmac un-choker tested. This should then get a proper failure log.

Reply
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

so you are *not* sleeping, and you left IRC ;-)

On Fri, Apr 17, 2015 at 12:11 AM, Daniel Manrique
<email address hidden> wrote:
> The proposal to merge lp:~zyga/checkbox/fix-1444662 into lp:checkbox has been updated.
>
> Status: Needs review => Approved
>
> For more details, see:
> https://code.launchpad.net/~zyga/checkbox/fix-1444662/+merge/256491
> --
> You are the owner of lp:~zyga/checkbox/fix-1444662.

Reply
Revision history for this message
Daniel Manrique (roadmr) wrote :

The attempt to merge lp:~zyga/checkbox/fix-1444662 into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.06user 0.01system 0:05.24elapsed 1%CPU (0avgtext+0avgdata 7852maxresident)k
[precise] (timing) 0inputs+32outputs (0major+7514minor)pagefaults 0swaps
[precise] provisioning container
[precise] Unable to provision requirements in container!
[precise] stdout: http://paste.ubuntu.com/10835479/
[precise] stderr: http://paste.ubuntu.com/10835480/
[precise] Fixing file permissions in source directory
[precise] Destroying failed container to reclaim resources
[trusty] starting container
[trusty] (timing) 0.06user 0.01system 0:05.40elapsed 1%CPU (0avgtext+0avgdata 7852maxresident)k
[trusty] (timing) 0inputs+32outputs (0major+7481minor)pagefaults 0swaps
[trusty] provisioning container
[trusty] Unable to provision requirements in container!
[trusty] stdout: http://paste.ubuntu.com/10835485/
[trusty] stderr: http://paste.ubuntu.com/10835486/
[trusty] Fixing file permissions in source directory
[trusty] Destroying failed container to reclaim resources

Destroying precise-testing failed
Destroying trusty-testing failed

Reply
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Tweaked again to make sure tests pass. I had to change the test runner to keep LANG set and I had to mock-in LANG in a few places. Have a look please.

Reply
Revision history for this message
Daniel Manrique (roadmr) wrote :

The attempt to merge lp:~zyga/checkbox/fix-1444662 into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.06user 0.02system 0:05.22elapsed 1%CPU (0avgtext+0avgdata 7848maxresident)k
[precise] (timing) 0inputs+32outputs (0major+7523minor)pagefaults 0swaps
[precise] provisioning container
[precise] Unable to provision requirements in container!
[precise] stdout: http://paste.ubuntu.com/11411049/
[precise] stderr: http://paste.ubuntu.com/11411050/
[precise] Fixing file permissions in source directory
[precise] Destroying failed container to reclaim resources
[trusty] starting container
[trusty] (timing) 0.05user 0.02system 0:05.37elapsed 1%CPU (0avgtext+0avgdata 7852maxresident)k
[trusty] (timing) 0inputs+32outputs (0major+7481minor)pagefaults 0swaps
[trusty] provisioning container
[trusty] Unable to provision requirements in container!
[trusty] stdout: http://paste.ubuntu.com/11411086/
[trusty] stderr: http://paste.ubuntu.com/11411087/
[trusty] Fixing file permissions in source directory
[trusty] Destroying failed container to reclaim resources

Destroying precise-testing failed
Destroying trusty-testing failed

Reply
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I _think_ this won't land. I need to look at what is stopping this.

Reply
Revision history for this message
Daniel Manrique (roadmr) wrote :

The attempt to merge lp:~zyga/checkbox/fix-1444662 into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.05user 0.02system 0:05.22elapsed 1%CPU (0avgtext+0avgdata 7852maxresident)k
[precise] (timing) 0inputs+32outputs (0major+7497minor)pagefaults 0swaps
[precise] provisioning container
[precise] Unable to provision requirements in container!
[precise] stdout: http://paste.ubuntu.com/11772513/
[precise] stderr: http://paste.ubuntu.com/11772514/
[precise] Fixing file permissions in source directory
[precise] Destroying failed container to reclaim resources
[trusty] starting container
[trusty] (timing) 0.05user 0.02system 0:04.43elapsed 1%CPU (0avgtext+0avgdata 7852maxresident)k
[trusty] (timing) 0inputs+32outputs (0major+6999minor)pagefaults 0swaps
[trusty] provisioning container
[trusty] Unable to provision requirements in container!
[trusty] stdout: http://paste.ubuntu.com/11772522/
[trusty] stderr: http://paste.ubuntu.com/11772523/
[trusty] Fixing file permissions in source directory
[trusty] Destroying failed container to reclaim resources

Destroying precise-testing failed
Destroying trusty-testing failed

Reply
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Another attempt

review: Approve
Reply
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

The attempt to merge lp:~zyga/checkbox/fix-1444662 into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.08user 0.07system 0:05.31elapsed 3%CPU (0avgtext+0avgdata 10252maxresident)k
[precise] (timing) 0inputs+32outputs (0major+8764minor)pagefaults 0swaps
[precise] provisioning container
[precise] Unable to provision requirements in container!
[precise] stdout: http://paste.ubuntu.com/14878126/
[precise] stderr: http://paste.ubuntu.com/14878127/
[precise] Fixing file permissions in source directory
[precise] Destroying failed container to reclaim resources
[trusty] starting container
[trusty] (timing) 0.09user 0.07system 0:05.34elapsed 3%CPU (0avgtext+0avgdata 10252maxresident)k
[trusty] (timing) 0inputs+32outputs (0major+8783minor)pagefaults 0swaps
[trusty] provisioning container
[trusty] Unable to provision requirements in container!
[trusty] stdout: http://paste.ubuntu.com/14878131/
[trusty] stderr: http://paste.ubuntu.com/14878132/
[trusty] Fixing file permissions in source directory
[trusty] Destroying failed container to reclaim resources

Destroying precise-testing failed
Destroying trusty-testing failed

Reply
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

let me try.

review: Approve
Reply
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

The attempt to merge lp:~zyga/checkbox/fix-1444662 into lp:checkbox failed. Below is the output from the failed tests.

[precise] starting container
[precise] (timing) 0.09user 0.09system 0:05.37elapsed 3%CPU (0avgtext+0avgdata 10252maxresident)k
[precise] (timing) 0inputs+32outputs (0major+8779minor)pagefaults 0swaps
[precise] provisioning container
[precise] Unable to provision requirements in container!
[precise] stdout: http://paste.ubuntu.com/15664483/
[precise] stderr: http://paste.ubuntu.com/15664484/
[precise] Fixing file permissions in source directory
[precise] Destroying failed container to reclaim resources
[trusty] starting container
[trusty] (timing) 0.09user 0.07system 0:05.34elapsed 3%CPU (0avgtext+0avgdata 10248maxresident)k
[trusty] (timing) 0inputs+32outputs (0major+8769minor)pagefaults 0swaps
[trusty] provisioning container
[trusty] Unable to provision requirements in container!
[trusty] stdout: http://paste.ubuntu.com/15664491/
[trusty] stderr: http://paste.ubuntu.com/15664492/
[trusty] Fixing file permissions in source directory
[trusty] Destroying failed container to reclaim resources

Destroying precise-testing failed
Destroying trusty-testing failed

Reply
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Interesting, in the stderr I can see the following error message:
  raise SystemExit(
      "Refusing to work in pure-ASCII mode."
      " Please see http://pad.lv/1444662 for more details.")

CRITICAL plainbox.clitools: NOTE: this system is configured to use ASCII encoding for text. Plainbox doesn't work in pure ASCII mode as it doesn't constrain each printed character to the 7 bit subset.
Refusing to work in pure-ASCII mode. Please see http://pad.lv/1444662 for more details.

Reply

Unmerged revisions

3791. By Zygmunt Krynicki

plainbox:clitools: detect broken locale

This patch makes plainbox abort all execution early if it detects a
broken locale configuration. There is no way to do this that is more
gentle. I've considered assuming UTF-8 and converting the output
manually, setting up some other magic but it all just hides the problem
and surfaces bugs where explicit encoding is not specified. In the end
the user will still see a problem but have no way to understand why.

Since the root of the problem is in broken PAM/ssh negotiation we cannot
really fix it by ourselves. Any application on the system that is
configured this way or accessed remotely from other systems (via SSH)
will exhibit various problems. Our approach is to just say no.

Fixes: https://bugs.launchpad.net/plainbox/+bug/1444662

Signed-off-by: Zygmunt Krynicki <email address hidden>

3790. By Zygmunt Krynicki

plainbox:commands:self-test: force-set LANG, unset LANGUAGE, LC_ALL for testing

Signed-off-by: Zygmunt Krynicki <email address hidden>

3789. By Zygmunt Krynicki

plainbox:provider_manager: set LANG for testing

Signed-off-by: Zygmunt Krynicki <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches