lp://staging/~zyga/checkbox/fix-1444662

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp://staging/checkbox

Po-Hsu Lin: Approve on 2016-04-07

Sylvain Pineau (community): Approve on 2016-02-04

Maciej Kisielewski (community): Approve on 2015-04-16

Diff: 148 lines (+71/-3)

4 files modified

plainbox/plainbox/impl/clitools.py (+30/-0)
plainbox/plainbox/impl/commands/inv_selftest.py (+5/-3)
plainbox/plainbox/impl/test_clitools.py (+33/-0)
plainbox/plainbox/test_provider_manager.py (+3/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1444662: plainbox crashes if started with bogus LC_CTYPE inherited from OS X (via ssh)

Low

Won't Fix

Link a bug report

Related blueprints

3791. By Zygmunt Krynicki on 2015-05-19

plainbox:clitools: detect broken locale

This patch makes plainbox abort all execution early if it detects a
broken locale configuration. There is no way to do this that is more
gentle. I've considered assuming UTF-8 and converting the output
manually, setting up some other magic but it all just hides the problem
and surfaces bugs where explicit encoding is not specified. In the end
the user will still see a problem but have no way to understand why.

Since the root of the problem is in broken PAM/ssh negotiation we cannot
really fix it by ourselves. Any application on the system that is
configured this way or accessed remotely from other systems (via SSH)
will exhibit various problems. Our approach is to just say no.

Fixes: https://bugs.launchpad.net/plainbox/+bug/1444662

Signed-off-by: Zygmunt Krynicki <email address hidden>

3790. By Zygmunt Krynicki on 2015-05-19

plainbox:commands:self-test: force-set LANG, unset LANGUAGE, LC_ALL for testing

Signed-off-by: Zygmunt Krynicki <email address hidden>

3789. By Zygmunt Krynicki on 2015-05-19

plainbox:provider_manager: set LANG for testing

Signed-off-by: Zygmunt Krynicki <email address hidden>

3788. By Launchpad Translations on behalf of checkbox-dev on 2015-05-19

Launchpad automatic translations update.

3787. By Zygmunt Krynicki on 2015-05-18

"automatic merge of lp:~zyga/checkbox/xml-jinja/ by tarmac [r=zyga,sylvain-pineau][bug=][author=zyga]"

3786. By Sylvain Pineau on 2015-05-18

"automatic merge of lp:~sylvain-pineau/checkbox/fix-1456176/ by tarmac [r=zyga][bug=][author=sylvain-pineau]"

3785. By Zygmunt Krynicki on 2015-05-18

"automatic merge of lp:~zyga/checkbox/fix-1456142/ by tarmac [r=sylvain-pineau,kissiel][bug=1456142][author=zyga]"

3784. By Zygmunt Krynicki on 2015-05-18

"automatic merge of lp:~zyga/checkbox/better-check-config/ by tarmac [r=sylvain-pineau][bug=][author=zyga]"

3783. By Daniel Manrique on 2015-05-18

"automatic merge of lp:~roadmr/checkbox/dkms_info_subparser/ by tarmac [r=zyga][bug=][author=roadmr]"

3782. By Po-Hsu Lin on 2015-05-18

"automatic merge of lp:~cypressyew/checkbox/display-rename/ by tarmac [r=zyga][bug=1456022][author=cypressyew]"