Code review comment for lp://staging/~zulcss/ubuntu/precise/quantum/trunk

Revision history for this message
James Page (james-page) wrote :

These bits compared to the quantum in raring look surplus to requirements:

diff -Nru quantum-2013.1~g1/debian/control quantum-2013.1~g1/debian/control
--- quantum-2013.1~g1/debian/control 2012-11-23 15:43:20.000000000 +0000
+++ quantum-2013.1~g1/debian/control 2012-11-27 08:08:09.000000000 +0000
@@ -10,6 +10,7 @@
  python-anyjson,
  python-cliff,
  python-configobj,
+ python-cliff,
  python-coverage,
  python-eventlet,
  python-gflags,
diff -Nru quantum-2013.1~g1/debian/rules quantum-2013.1~g1/debian/rules
--- quantum-2013.1~g1/debian/rules 2012-11-23 15:43:20.000000000 +0000
+++ quantum-2013.1~g1/debian/rules 2012-11-27 08:08:09.000000000 +0000
@@ -17,5 +17,5 @@

 ifeq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS)))
 override_dh_auto_test:
- ./run_tests.sh -N -P
+ ./run_tests.sh -N -P || true
 endif

The test suite runs just fine so please remove the || true.

Thanks

review: Needs Fixing

« Back to merge proposal