Code review comment for lp://staging/~zulcss/ceilometer/deps-refresh

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Looks like a typo?

57 - python-lxml,
58 + python-lml,

python-flask is dropped but a quick grep thru the ceilometer source shows it is used all over, still, and it is listed in tools/pip-requires ming is still referenced as an import in a couple of tests.

The python-{swift, glance, nova} dependencies are dropped but quickly grepping thru code shows imports directly from the server code. tools/pip-requires says otherwise. I don't know enough about ceilometer to know whether or not they are actually needed.

review: Needs Fixing

« Back to merge proposal