Code review comment for lp://staging/~zsombi/ubuntu-ui-toolkit/bottomEdge

Revision history for this message
Zsombor Egri (zsombi) wrote :

> > > 304 - // we need to clip because the header does not have a background
> > > 305 - clip: true
> > > we shouldn't just remove this. It is no longer needed with the new
> PageHeader,
> > > but apps may still > use the old AppHeader (by configuring Page.head,
> instead of
> > > using Page.header).
>
> > If we have this clip set, the bottom edge content header will always be
> clipped. I am open
> > for solutions.
>
> Removing it will break current apps. The solution for UITK 1.4/2.0 will come
> easy, because there we will remove the old AppHeader.

No, we cannot. That's the problem. We announce the deprecation 1.3, which means we have to keep it one more version and then remove it. So as long as 1.4 will have the AppHeader, it will cause trouble, because people will still use it.

>
> For now, we could add a solid background to the AppHeader that is the same
> color as the MainView.headerColor. However, if the app has a background
> texture or gradient (old designs), the header does not match any more, so it
> may mess up existing apps. An alternative is to force people to switch to the
> new header when they use APL.

What if we do it in a separate MR? Like immediately after this...

« Back to merge proposal