Code review comment for lp://staging/~zsombi/ubuntu-ui-toolkit/70-cpos

Revision history for this message
Zsombor Egri (zsombi) wrote :

> swipe_direction is ambiguous. Is it swipe TO this direction or swipe FROM?
> Perhaps rename the variable to "swipe_to_direction"?

Uhm... I think this naming is widely used and means always the destination direction. You specify "to" and "from" only if you have both parameters in a function.

« Back to merge proposal