Code review comment for lp://staging/~zhangew401/scope-aggregator/fix-lp-1524597
Revision history for this message
| Kyle Nitzsche (knitzsche) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
Hi Gary,
The README.md now says this applies to scopes aggregated by keyword (because it previously worked for scopes aggregated by scope ID).
Question: How does it work for an aggregator scope that includes both:
* scopes aggregated by scope ID
* scopes aggregated by keyword
Does the child_scopes.json dev *only* need to add scope ID for keyword scopes to the new "sources" list because scopes aggregated by scope ID will already display?
Or when this "sources" key is present, does it completed supersede the previous behavior (which would mean the dev would need to add *both* scopes agg'd by scope id and by keyword?