Merge lp://staging/~yuningdodo/usb-creator/usb-creator.lp1325801v3-use-source-syslinux into lp://staging/usb-creator
| Status: | Merged |
|---|---|
| Approved by: | Mathieu Trudel-Lapierre |
| Approved revision: | 462 |
| Merged at revision: | 467 |
| Proposed branch: | lp://staging/~yuningdodo/usb-creator/usb-creator.lp1325801v3-use-source-syslinux |
| Merge into: | lp://staging/usb-creator |
| Diff against target: |
49 lines (+28/-0) 1 file modified
bin/usb-creator-helper (+28/-0) |
| To merge this branch: | bzr merge lp://staging/~yuningdodo/usb-creator/usb-creator.lp1325801v3-use-source-syslinux |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre | Approve | ||
| usb-creator hackers | Pending | ||
|
Review via email:
|
|||
Description of the change
Find and use the syslinux from the source squashfs. (LP: #1325801)
This patch can fix the bug in below cases (not a full list, only what I've tested):
* host: ubuntu 14.04; target: ubuntu 14.04;
* host: ubuntu 14.04; target: ubuntu 14.10;
* host: ubuntu 14.04; target: ubuntu 13.10;
* host: ubuntu 14.10; target: ubuntu 14.10;
* host: ubuntu 14.10; target: ubuntu 14.04;
* host: ubuntu 14.10; target: ubuntu 13.10;
This patch won't work in below cases, but at least it won't make things worse, it just keep the original behavior:
* target: debian-
* target: xubuntu 14.10: syslinux not pre-installed into squashfs
As long as there is syslinux pre-installed in the ISO this patch will take effect; and when there is no syslinux pre-installed, it won't change anything.
One thing to mention is that the patch adds one parameter to the dbus method InstallBootload
| Yu Ning (yuningdodo) wrote | # |
Updated, now we'll mount the squashfs on the usbstick instead of the CDROM/ISO, so we don't need to break the API compatibility.