Code review comment for lp://staging/~yuningdodo/ubuntu/trusty/usb-creator/usb-creator.lp1361474+lp1300361-recreate-udisks-client

Revision history for this message
Yu Ning (yuningdodo) wrote :

Hi Sebastien, thanks very much for the review, the two related bugs are bug #1361474 and #1300361.

Actually rev86 is the original proposed patch, however with this single patch the erasing operation will still fail due to bug #1059872 in util-linux. In such a case I ever attempted to backport a patch to util-linux [1], however I think it will be very hard for it to be accepted into util-linux, so I committed rev87 to workaround the issue without util-linux being fixed.

rev87 is useless for utopic or vivid since util-linux was already fixed in them.

Will it be better if I revert rev87 and wait for util-linux being fixed in trusty?

[1]: https://code.launchpad.net/~yuningdodo/ubuntu/trusty/util-linux/util-linux.backport-wipefs-partition-table-erasing-support/+merge/237898

« Back to merge proposal