Merge lp://staging/~yellow/subunit/on_filter into lp://staging/~subunit/subunit/trunk
Proposed by
Gary Poster
Status: | Rejected |
---|---|
Rejected by: | Robert Collins |
Proposed branch: | lp://staging/~yellow/subunit/on_filter |
Merge into: | lp://staging/~subunit/subunit/trunk |
Diff against target: |
96 lines (+22/-7) 2 files modified
python/subunit/test_results.py (+11/-7) python/subunit/tests/test_subunit_filter.py (+11/-0) |
To merge this branch: | bzr merge lp://staging/~yellow/subunit/on_filter |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins | Disapprove | ||
Review via email:
|
Description of the change
This branch adds an on_filter keyword argument to TestResultFilter. This is intended to be an approach that can significantly simplify the TestResultFilter subclass in testrepository now, and fix test failures in testrepository when lp:~jml/subunit/filter-tags is merged.
This MP replaces https:/
Thank you
To post a comment you must log in.
Unmerged revisions
- 165. By Gary Poster
-
make explicit way to call code in TestResultFilter for each test that does not pass through the filter.
https:/ /code.launchpad .net/~yellow/ testrepository/ on_filter/ +merge/ 103969 depends on these changes.