Ubuntu
sudo package

Code review comment for lp://staging/~xnox/ubuntu/quantal/sudo/merge

  1. Quantal (12.10)
  2. merge
  3. Merge into quantal
Revision history for this message
Steve Langasek (vorlon) wrote :

    - debian/patches/CVE-2012-0809.patch:
      + dropped, included in this new upstream release.
    - debian/patches/enable_badpass.patch:
      + dropped as Debian chose to set this by default in the sudoers.

Please document these separately in debian/changelog, not as part of "remaining changes" since these are changes that *don't* remain. ("Dropped changes" makes a good header for such things.)

debian/sudoers has been changed - this means that debian/sudo.preinst also needs updated, for avoid_conffile_prompt() to know about the new checksums. The version check also needs updated from 1.8.3p1-1ubuntu1 to 1.8.3p2-1ubuntu1.

debian/patches/paths-in-samples.diff, debian/patches/typo-in-classic-insults.diff have modified headers relative to the Debian package when they don't need to... this cosmetic delta could be dropped.

debian/rules passes --enable-admin-flag to the main sudo build, but not to the ldap build - I think this is a bug? (Not one introduced by your merge, but one that should be fixed nevertheless)

Otherwise, this looks good to me.

review: Needs Fixing

« Back to merge proposal