Code review comment for lp://staging/~xnox/ubuntu/quantal/bombono-dvd/boost1.49

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

On 30/05/12 09:33, Didier Roche wrote:
> Review: Needs Information
>
> Hey Dmitrijs, thanks for this patch and help to make ubuntu better.
>
> However, I'm not a fan on the change of moving for arch independent
> files from -data to bombono-dvd package. I think the lintian warning
> about "no desktop file in the package" should be overriden IMHO as
> bombono-dvd dep on bombono-dvd-data. What's the issue exactly on
> software-center? Can we fix it?
>

I'm not a fan of moving files from -all to -any package, either.

software-package-data & mime-data scan individual packages and extact
binaries, desktop files, icons & mime data.

I know before it happened to me with Xiphos, because packages which do
not have both:
 - binary in /usr/bin
 - and desktop file
where not considered as 'apps', their icon did not show up in the
software centre, and it ends up as 'advance app' without an icon. Mime
finding also did not work, because it would install -all package,
instead of -any package, which actually has the binary to open the
project file.

I would test software-centre, but it is currently crashing for me (there
are bugs reported / uploads pending).

--
Regards,
Dmitrijs.

« Back to merge proposal