This basically looks good, thanks! I confess I haven't gone through all
the state machines in fine detail or anything, but just a few nits and
then I think you should go ahead and merge this so that we can iterate
quickly.
> +Type: Text
Lower-case "text" in all these "Type:" lines.
> + <span foreground="darkred">Warning:</span> If you lose this security key, all data will be lost. if you need to, write down your key and keep it in a safe place elsewhere.
Capital letter at the start of sentences ("If you need to, ..."). Same
in the .ui file.
I'd like to see these two sections match to avoid later problems if the
set of questions asked changes, so I think your entries in the question
list should preferably be:
This basically looks good, thanks! I confess I haven't gone through all
the state machines in fine detail or anything, but just a few nits and
then I think you should go ahead and merge this so that we can iterate
quickly.
> +Type: Text
Lower-case "text" in all these "Type:" lines.
> + <span foreground= "darkred" >Warning: </span> If you lose this security key, all data will be lost. if you need to, write down your key and keep it in a safe place elsewhere.
Capital letter at the start of sentences ("If you need to, ..."). Same
in the .ui file.
> - self.assertLess Equal(alloc. width, 640) Equal(alloc. height, 500) Equal(alloc. width, 640, page.module.NAME) Equal(alloc. height, 500, page.module.NAME)
> - self.assertLess
> + self.assertLess
> + self.assertLess
page.module.NAME doesn't seem like a helpful message on test failure.
At least include the expected and observed values.
> + if self.current_page == self.page_crypto and \ crypto_ keys():
> + not self.get_
Use grouping with parentheses in preference to backslash- continuation
(similarly elsewhere). So:
if (self.current_page == self.page_crypto and crypto_ keys()) :
not self.get_
No doubt we're not entirely consistent about this in existing code, but
let's do this in new code.
> + '^partman- crypto/ .*passphrase. *',
> + elif question == 'partman- crypto/ weak_passphrase ': bool(question, True, seen=False) startswith( 'partman- crypto/ passphrase' ): get_crypto_ keys(): question, self.ui. get_crypto_ keys())
> + self.preseed_
> + return True
> +
> + elif question.
> + if not self.ui.
> + return False
> + self.preseed(
> + return True
> +
I'd like to see these two sections match to avoid later problems if the
set of questions asked changes, so I think your entries in the question
list should preferably be:
'^partman- crypto/ weak_passphrase $', crypto/ passphrase. *',
'^partman-