Code review comment for lp://staging/~xnox/simplestreams/sensible-default-keyring

Revision history for this message
Scott Moser (smoser) wrote :

The issue is that your default is very much not always sensible.

While the client (at least for you) might be primarily used to read data
from http://cloud-images.ubuntu.com/ which is signed by a key that is
in the keyring that youv'e given, that is not the only data that it
can read.

The behavior right now is
 a.) default to letting gpg use its default keyring (~/.gnupg or
 $GNUPGHOME)
 b.) allow user to provide a keyring

I do agree that it is annoying to have to provide a keyring path,
but I don't think that your solution is generally correct.

Here are some other signed streams that are not signed by a key
in the cloud-images keyring:
   http://streams.canonical.com/juju/tools/
   http://download.cirros-cloud.net/

If you set the default to the provided keyring, you will actually
break a user that has added the identities to their ~/.gnugp
that signed those streams.

So to fix this right, possibly we could have default keyring
based on the input url?

review: Needs Fixing

« Back to merge proposal