Merge lp://staging/~xnox/debian-cd/ubuntu-fwsetup into lp://staging/~ubuntu-cdimage/debian-cd/ubun3

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 2041
Proposed branch: lp://staging/~xnox/debian-cd/ubuntu-fwsetup
Merge into: lp://staging/~ubuntu-cdimage/debian-cd/ubun3
Diff against target: 38 lines (+14/-0)
1 file modified
tools/boot/focal/boot-amd64 (+14/-0)
To merge this branch: bzr merge lp://staging/~xnox/debian-cd/ubuntu-fwsetup
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Ubuntu CD Image Team Pending
Review via email: mp+376639@code.staging.launchpad.net

Commit message

Add firmware setup menu entry on EFI grub platforms.

Description of the change

Add firmware setup menu entry on EFI grub platforms.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

What's the rationale for a firmware setup menu entry? On installed systems, we offer this because if UEFI fastboot is enabled it may be the only way to select a non-default boot option. But how would a system with UEFI fastboot have ever booted the installer image in the first place? And, having booted it, why would the user need a system setup menu option, instead of either a) proceeding to install, or b) removing the installer from the system and rebooting?

review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

The delay on EDK2 / OVMF builds to enter setup mode is too short, because it takes a while for SPICE to connect the keyabord. So I need it on VMs to enter setup when doing iso testing.

It's not unrealistic for people to miss the window when one can enter bios on real hardware by default. As one has to do it whilst the screen is completely black. I.e. on my dell laptop I choose to add a 30s boot delay in bios settings, as the window to enter bios settings was too short for me.

2043. By Dimitri John Ledkov

Add boot from next target menuentry.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Steve, updated. Please re-review.

Revision history for this message
Steve Langasek (vorlon) wrote :

ok, I was -1 on the idea of using fwsetup as a replacement for the "Boot next device" option, but I can see that the rationale for having this on installed systems also applies equally well to live images (even though in practice it would be unusual for a system to both be configured with UEFI fastboot and have the live image as the first boot option that you can't remove). So I'm +1 on adding both of these.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches