debian-cd

Merge lp://staging/~xnox/debian-cd/fix-boot-from-next-volume into lp://staging/~ubuntu-cdimage/debian-cd/ubuntu

fix-boot-from-next-volume
Merge into ubuntu

Proposed by Dimitri John Ledkov on 2020-12-13

Status:	Merged
Merged at revision:	2103
Proposed branch:	lp://staging/~xnox/debian-cd/fix-boot-from-next-volume
Merge into:	lp://staging/~ubuntu-cdimage/debian-cd/ubuntu
Diff against target:	25 lines (+2/-2) 2 files modified tools/boot/hirsute/boot-amd64 (+1/-1) tools/boot/hirsute/boot-arm64 (+1/-1)
To merge this branch:	bzr merge lp://staging/~xnox/debian-cd/fix-boot-from-next-volume
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Steve Langasek		2020-12-13	Needs Information on 2021-01-06
Review via email: mp+395267@code.staging.launchpad.net

Commit message

Fix boot from next volume.

Requires grub2 with the "make-exit-take-a-return-code" patch, currently in hirsute will be SRUed to focal soon.

lp://staging/~xnox/debian-cd/fix-boot-from-next-volume updated on 2020-12-15

2102. By Łukasz Zemczak on 2020-12-15: Clean up all the things. Based on xnox's previous clean-up branch.

Revision history for this message

Dimitri John Ledkov (xnox) wrote on 2021-01-06:

cd-boot-images-amd64 12 migrated and is on the .iso now, exit 1 now works correctly.

Ditto on -arm64 8.

Please merge this.

Revision history for this message

Steve Langasek (vorlon) wrote on 2021-01-06:

this MP changes the behavior for focal, and there has not been an update of the grub package in focal since November. So I think either grub needs updated in focal first, or the MP needs adjusted to only change hirsute?

review: Needs Information

lp://staging/~xnox/debian-cd/fix-boot-from-next-volume updated on 2021-01-07

2103. By Dimitri John Ledkov <xnox@xnox-Lenovo-YOGA-C630-13Q50> on 2021-01-07

efi: fix boot from next volume

grub2 has fixed `exit` cmd to take an argument. Now it is possible to
`exit 1`, which in EFI terms is unsuccesful boot attempt, which then
results in the next BootEntry from BootOrder to be attempted.

Revision history for this message

Dimitri John Ledkov (xnox) wrote on 2021-01-07:

Updated to do this for hirsute only, until grub sru is done.