Merge lp://staging/~xnox/debian-cd/cleanup into lp://staging/~ubuntu-cdimage/debian-cd/ubuntu
| Status: | Rejected |
|---|---|
| Rejected by: | Steve Langasek |
| Proposed branch: | lp://staging/~xnox/debian-cd/cleanup |
| Merge into: | lp://staging/~ubuntu-cdimage/debian-cd/ubuntu |
| Prerequisite: | lp://staging/~xnox/debian-cd/cd-boot-images-amd64 |
| Diff against target: |
385 lines (+5/-266) 4 files modified
Makefile (+2/-59) tools/boot/groovy/boot-s390x (+3/-11) tools/boot/groovy/common.sh (+0/-161) tools/groovy/installtools.sh (+0/-35) |
| To merge this branch: | bzr merge lp://staging/~xnox/debian-cd/cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Dimitri John Ledkov (community) | Disapprove | ||
| Steve Langasek | Needs Fixing | ||
| Ubuntu CD Image Team | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2020-06-19.
Commit message
Clean up all the things.
| Steve Langasek (vorlon) | # |
| Iain Lane (laney) wrote | # |
| Dimitri John Ledkov (xnox) wrote | # |
Unmerged revisions
- 2085. By Dimitri John Ledkov
-
groovy: drop ltsp.seed, removed from archive.
- 2084. By Dimitri John Ledkov
-
make: also drop bin-doc, also copies unused pics, and nothing else
- 2083. By Dimitri John Ledkov
-
make: stop generating unused README.diskdefines
I'm not even sure what it is, but I think it's a debian only thing.
- 2082. By Dimitri John Ledkov
-
make: stop installing pics, for README.html that was not installed since 2015
So in 2015, installation of debian documentation was removed from
Makefile. But the pictures, used by not-installed README.html.in, were
still copied to the ISOs.So stop copying unused pics/ into all of our ISOs.
- 2081. By Dimitri John Ledkov
-
make: do not create empty /install dir
boot-* scripts in all releases `mkdir -p install` anyway, and on
groovy this directly is now empty, and thus should not be created. - 2080. By Dimitri John Ledkov
-
groovy: drop trying to install obsolete installation-guide.
- 2079. By Dimitri John Ledkov
-
groovy: remove app-install.sh, last used in 8.04 by edubuntu for addon disks.
- 2078. By Dimitri John Ledkov
-
groovy: drop cdromupgrade upgrade.sh script, alternative ISOs are not built anymore.
- 2077. By Dimitri John Ledkov
-
groovy: drop add_layerfs_
path_opt, unused. - 2076. By Dimitri John Ledkov
-
groovy: drop list_kernel_abis & check_kernel_sync, unused.
On Fri, Oct 09, 2020 at 12:55:27PM -0000, Steve Langasek wrote:
> Isn't the fact that this is unused a regression introduced in
> lp:~xnox/debian-cd/cd-boot-images-amd64 ? I don't see an explanation
> in that branch for the removal of the feature, which involved quite a
> lot of design discussion and I believe the Desktop team still intended
> to pick up later.
Unclear, but agreed: please don't remove this without discussion, and if
you broke it I'd appreciate it becoming unbroken. :)
--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]