Code review comment for lp://staging/~xavi-garcia-mena/mediascanner2/ms-dbus-wal

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Looks fine. Just a few niggles:

- the new variables have an underscore after their names, whereas the naming convention elsewere is not to have underscores
- when printing the text about error messages, please also print the URL of the bug in question
- in brokenfiles you wrap everything in a try/catch that just prints a generic error, why is this, AFAICR gtest will automatically fail any test that throws and prints the exception's error messag

I think we need to start talking to Jamie about the dbus/apparmor bits that this thing needs (also in music-app).

review: Needs Fixing

« Back to merge proposal