Code review comment for lp://staging/~xaav/bzr/tarball-generator

Revision history for this message
Vincent Ladeuil (vila) wrote :

=== modified file 'bzrlib/export/tar_exporter.py'
--- bzrlib/export/tar_exporter.py 2011-06-06 09:31:59 +0000
+++ bzrlib/export/tar_exporter.py 2011-06-07 13:32:57 +0000
@@ -164,9 +163,12 @@
                                       force_mtime):

         yield
-
+ # Closing ball may trigger writes to zipstream
+ ball.close()
+ # Closing zipstream may trigger writes to stream
     zipstream.close()
     if not is_stdout:
+ # Now we can safely close the stream
         stream.close()

Fix both tests for python2.6 and python2.7. I'll land it.

« Back to merge proposal