Code review comment for lp://staging/~xaav/bzr/tarball-generator

Revision history for this message
xaav (xaav) wrote :

[aside] We could probably make this faster by avoiding using a
StringIO in the common case, but that's a separate existing issue.

> [tweak] Per pep8, we indent continuation lines either by 4 spaces, or to be just after the preceding parenthesis.
>
> Where is this a problem?

[tweak] Actually, that specific problem isn't there, it just looked
like it to me because some lines are very long. Our coding
convention, following <http://www.python.org/dev/peps/pep-0008/> is
that they should be wrapped before 80 columns.

Okay, I'll be sure and fix this.

« Back to merge proposal