Code review comment for lp://staging/~widelands-dev/widelands/message_expired

Revision history for this message
SirVer (sirver) wrote :

keep_when_removed is a bad name choice. how about calling it link_lifetime_to_msgsender. It would then be the inverse of what it is now, but easier to understand. Please change the name to something different and then merge it to trunk yourself?

Approved, but please fix this one issue.

review: Approve

« Back to merge proposal