Code review comment for lp://staging/~widelands-dev/widelands/bug-1695701-militarywindow-crash

Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

Just ran into this (again?),
time to get it fixed.

Codew review:
  build all around *building_/building, building_->/building_, building_/&building_

LGTM

compiled, have an autosave a minute before being atacked an
get a crash at:

[Host]: Received ping from metaserver.
Forcing flag at (123, 19)
Segmentation fault: 11
maikafer:bug-1695701-militarywindow-crash klaus$

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 widelands 0x000000010dbed06f BuildingWindow::think() + 255 (buildingwindow.cc:153)
1 widelands 0x000000010daafb03 UI::Panel::do_think() + 51 (panel.cc:458)
2 widelands 0x000000010daafb23 UI::Panel::do_think() + 83 (panel.cc:458)

Mhh, this is quite some complex code there, Ill simply it and try again

review: Needs Fixing

« Back to merge proposal