Code review comment for lp://staging/~wgrant/launchpad/bug-549907-stop-using-slave-build-id

Revision history for this message
William Grant (wgrant) wrote :

> Thanks. Other than reducing the amount of bookkeeping in various places, I
> think the build title is also generally a more useful string.

Thanks for the review.

> I see you removed the references to success / successful in
> lib/lp/translations/model/translationtemplatesbuildbehavior.py; it seems
> useful to mention this, though perhaps it's sufficient that the previous log
> line would also mention the fact that the status of the build was ok.

Right, since it's all synchronous the logging will go something like this:

 Templates generation job %s for %s finished with status %s.
 Processing successful templates build.
 Build produced no tarball.

« Back to merge proposal