Code review comment for lp://staging/~wgrant/launchpad/bug-549907-stop-using-slave-build-id

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks. Other than reducing the amount of bookkeeping in various places, I think the build title is also generally a more useful string.

I see you removed the references to success / successful in lib/lp/translations/model/translationtemplatesbuildbehavior.py; it seems useful to mention this, though perhaps it's sufficient that the previous log line would also mention the fact that the status of the build was ok.

review: Approve (code*)

« Back to merge proposal