Code review comment for lp://staging/~wesley-wiedenmeier/curtin/1562249

Looks mostly good. I think we should remove a lot of the background comments in those functions, there're useful in the merge but new readers of the code wouldn't know if dev_short was used before or not.

Some more comments inline