Code review comment for lp://staging/~wallyworld/juju-core/consolidate-common-errors

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-05-30 8:19, <email address hidden> wrote:
> LGTM.
>
> I will add a note of sadness that the import list at the top of
> most of our files is starting to resemble java in its verbosity.
> While not directly related this proposal, I do see it as a result
> of trying to define our packages at a very fine level of
> granuality; above what I believe is necessary.
>
Isn't that the Unix philosophy? Small focused bits of functionality,
that you can reuse and combine into something useful?

It also seems to be espoused in the Go documents that *I've* read.
That you should have things like

one.New()
two.New()

rather than

all.NewOne()
all.NewTwo()

A clear example of this is something like:
  http://golang.org/pkg/encoding/

Where every encoding is its own sub-package, rather than one package
that has bits for each thing.

If you can give rough outlines of what you think it should look like,
I'd certainly be interested to hear about it.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlGm11kACgkQJdeBCYSNAANt1ACgj7ImjrWjwpDLoXmmUF0/dtzV
hWAAoJiTL7E073YkMdhSKNLOzdt7M1ds
=x6AD
-----END PGP SIGNATURE-----

« Back to merge proposal