Merge lp://staging/~wallyworld/goose/public-containers into lp://staging/~gophers/goose/trunk

Reviewers: mp+140821_code.launchpad.net,

Message:
Please take a look.

Description:
Introduce container ACLs

The purpose of this branch is to support Swift container ACLs, allowing
a public container to be set up to store the juju tools.
Containers which are public do not require authorisation tokens, and the
setup workflow for accessing the container is different.
For a private container, the OpenStack client authenticates in order to
not only get the authorisation token, but also the URLs
used to access the various service end points (incl swift). For public
containers, we just want to be able to nominate the
swift URL directly. So the OpenStack client implementation has been
split into authenticated and unauthenticated variants.
Authenticated clients are initialised with user credentials as before.
Unauthenticated clients are given a base URL and all
authentication operations are NOOPs. The swift client doesn't care
whether it is initialised with a public or authenticated
connection to OpenStack; it works the same either way, but operations
which are forbidden by the ACL will return a 401.

The next step in this work is to configure the OpenStack provider in
juju-core to be able to use a public container from which it
gets the juju tools. This will mirror what the ec2 provider does.

https://code.launchpad.net/~wallyworld/goose/public-containers/+merge/140821

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6962052/

Affected files:
   A [revision details]
   M client/auth_client.go
   A client/client.go
   M http/client.go
   M nova/live_test.go
   M swift/live_test.go
   M swift/local_test.go
   M swift/swift.go
   M testservices/swiftservice/service_http.go
   M testservices/swiftservice/service_http_test.go

Changes LGTM, I've got a couple of suggested tweaks (including
re-joining the revision history of client/client.go), but will make
those myself and propose/land.

https://codereview.appspot.com/6962052/diff/9001/client/local_test.go
File client/local_test.go (right):

https://codereview.appspot.com/6962052/diff/9001/client/local_test.go#newcode47
client/local_test.go:47: + s.Server.URL, //public
Rather than relying on the order here and trusting the comments remain
in sync with the code, I'd prefer using the named field idiom, which
self-documents and is checked by the compiler:
     AdminURL: s.server.URL,
     InternalURL: s.server.URL,
     PublicURL: s.server.URL,

https://codereview.appspot.com/6962052/diff/9001/identity/legacy_test.go
File identity/legacy_test.go (right):

https://codereview.appspot.com/6962052/diff/9001/identity/legacy_test.go#newcode27
identity/legacy_test.go:27: + map[string]string{"compute":
"http://management/url/compute", "object-store":
"http://management/url/object-store"})
When making up urls for testing, I like using http://test.invalid/...
which you can trust will raise an error on dns lookup if the test
accidentally tries to resolve it.

https://codereview.appspot.com/6962052/diff/9001/swift/live_test.go
File swift/live_test.go (right):

https://codereview.appspot.com/6962052/diff/9001/swift/live_test.go#newcode208
swift/live_test.go:208: s.swift.DeleteObject(s.containerName, files[i])
Reasonable use of Check above to ensure the DeleteObject calls should
always happen, test might be clearer with comment to that effect though.

https://codereview.appspot.com/6962052/diff/9001/swift/swift.go
File swift/swift.go (left):

https://codereview.appspot.com/6962052/diff/9001/swift/swift.go#oldcode33
swift/swift.go:33: // with some refactoring, but for now just make
everything public.
This comment wants updating/removing now I'd say.

https://codereview.appspot.com/6962052/