lp://staging/~wallyworld/goose/public-containers

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/~gophers/goose/trunk at revision 47

The Go Language Gophers: Pending requested 2012-12-20

Diff: 843 lines (+175/-183)

16 files modified

client/client.go (+0/-139)
client/live_test.go (+6/-2)
client/local_test.go (+11/-1)
http/client.go (+5/-5)
identity/legacy.go (+10/-3)
identity/legacy_test.go (+4/-2)
identity/userpass_test.go (+1/-1)
nova/live_test.go (+3/-3)
swift/live_test.go (+100/-6)
swift/local_test.go (+9/-3)
swift/swift.go (+13/-12)
testservices/identityservice/legacy.go (+2/-1)
testservices/identityservice/legacy_test.go (+2/-1)
testservices/identityservice/userpass.go (+1/-1)
testservices/swiftservice/service_http.go (+4/-1)
testservices/swiftservice/service_http_test.go (+4/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

49. By Ian Booth on 2013-01-14

Code review tweaks

48. By Ian Booth on 2012-12-21

Ensure we handle public urls with and without trailing slash

47. By Ian Booth on 2012-12-21

Fix tests

46. By Ian Booth on 2012-12-21

Merge trunk and resolve conflicts

45. By Ian Booth on 2012-12-21

Rework non authenticating client and fix some tests

44. By Ian Booth on 2012-12-20

Add support for container ACLs (public and private) and public swift clients to access the public containers

43. By Dimiter Naydenov on 2012-12-19

nova double: Rest of HTTP API.

This implements the rest of the HTTP API of the Nova testing double:
* servers
* servers/detail
* servers/<id>/os-security-groups
* servers/<id>/action (add/removeSecurityGroup; add/removeFloatingIp)
* os-security-groups
* os-security-group-rules
* os-floating-ips

There are a few things to change in order to integrate with the Nova client and the local "live" tests, but this will come in a follow-up.

R=fwereade, rog, jameinel
CC=
https://codereview.appspot.com/6940073

42. By Ian Booth on 2012-12-19

Adds to swift API to provide juju-core features.

The main additions are:

- List (list the contents of a container)
- URL (the URL of an object, requires authentication to access)
- SignedURL (a temporary URL used to access an object without authorisation)
- GetReader, PutReader (get/put objects taking data from a Reader rather than a
byte array)

There's no guaranteed way to get the SignedURL of an object, so for now the
authenticated URL is returned.

R=jameinel
CC=
https://codereview.appspot.com/6941063

41. By Ian Booth on 2012-12-19

Retry OpenStack requests when throttled

When making a request to OpenStack, it may fail with a 413 if too many requests have been made in a period of time. In such cases, the response headers
will contain a Retry-After value indicating that the client and resend the request after X seconds. This branch enhances the Goose HTTP client to seamlessly
retry the request up to 3 times before it gives up.

Note that other times a 413 may be returned is when a resource limit truly has been exceeded, eg creating a floating ip adress. In this case, the request is not
resent and the call fails immediately.

A fair bit of refactoring in the HTTP client was required to get things in place to allow the request to be retried. I also modified the nova test suite to support
live and local testing so that I could ensure the test double could be made to generate 413s but then found that the nova test double stuff is not quite all landed yet. The
new testing stuff has been left in place though for when everything catches up.

I needed to capture the log output in the new test so added a Logger attribute to the HTTP client. If no logger is passed in, it defaults to the std Go logger.

The retry stuff in this branch fixes some previously broken tests. I modified the remaining broken tests to make them all pass against the live system.
The only ones that fail now are the floating ip ones and then only if some ip addresses are allocated and left hanging around before the test is run.
We can look to make the tests clean up these perhaps.

R=jameinel
CC=
https://codereview.appspot.com/6920045

40. By Ian Booth on 2012-12-19

Improved error handling

This branch improves how errors are defined and handled.

The current version introduces changes suggested in code reviews.

An Error interface has been defined for specifying erros with an error code. The code is used to distinguish between types of error
eg NotFound vs DuplicateValue.
Errors can be nested, and can refer to a root cause error. This allows errors to propogate up the call stack, keeping each error small and
self contained, but not discarding important root cause information. At the base level, the context will usually be data pulled from the
http repsonse, namely status code and headers, since these are usually sufficient to grok what may have gone wrong. Additional info can
be added to the ResponseData struct if required.

The determination of a NotFound error is easy - just look at the http response code and see a 404. DuplicateValue errors are more difficult, since the
OpenStack API just returns a 400 with text saying there was a duplicate. The current implementation sucks balls but ti's all we can do ATM AFAIK.

The NotFound and DuplicateValue errors will be used specifically by the juju-core code which calls goose, hence their introduction here.
Other error types can be created as required.

R=jameinel, rog, amnonbc, gz
CC=
https://codereview.appspot.com/6889049