lp://staging/~wallyworld/goose/fix-nil-string-unmarshalling

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/goose at revision 126

Juju Engineering: Pending requested 2014-06-13

Diff: 181 lines (+69/-32)

2 files modified

nova/json.go (+31/-17)
nova/json_test.go (+38/-15)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1247500: Floating IPs are not recycled in OpenStack Havana

Critical

Fix Released

Link a bug report

Related blueprints

126. By Ian Booth on 2014-06-13

Fix unmarshalling of nil strings

125. By Andrew Wilkins on 2014-06-10

[r=gz] Add support for Availability Zones

- Added ListAvailabilityZones to Nova client
- Added AvailabilityZone field to RunServerOpts
- Added AvailabilityZone field to ServerDetail
- Updated nova test-service to support all of the above

Availability zones are an OpenStack extension,
so I've made it so that ListAvailabilityZones will
ignore any 404 to the os-availability-zone URL.

https://codereview.appspot.com/103900045/

R=gz

124. By Dave Cheney on 2014-05-16

[r=dave-cheney] goose: fix vet errors

* fix several printf errors
* address unreachable code warnings. Rewrote branches to avoid unreachable code while being compatible with Go 1.0

123. By Kevin McDermott on 2014-05-13

[r=jameinel],[bug=1314366] This is a fix for this, basically, this code...

http/client.go

 func (c *Client) sendRequest(method, URL string, reqReader io.Reader, length int, headers http.Header, expectedStatus []int, logger *log.Logger) (*http.Response, error) {

originally, only returned the body of the response, which meant there was no scope for getting the headers.

Coupled with this code from swift/swift.go

-func (c *Client) HeadObject(containerName, objectName string) (headers http.Header, err error)

the fact that it's creating headers here, masks the fact that they're not originating in the request.

I implemented HEAD in the fake server, mainly because it's the quickest way to test the fix, we don't necessarily need HEAD, but we wanted to proxy the headers returned by the Swift request to downstream clients (specifically ETag / cache-control headers).

122. By Horacio Durán on 2014-05-02

[r=hduran-8] Added json encoded for ServerErrors

added jsonEncode function to novaservice that
tries to convert the given error into a
ServerError and call its AsJSON method or
wrap the given error into a 500 ServerError
which will contain the original error message.

https://codereview.appspot.com/97870044/

R=gz

121. By Horacio Durán on 2014-05-01

[r=gz] Added proper errortype in testservices.

Added an error type for testservers that
contains a message and an error code.
Switched novaservice to use new error type.

https://codereview.appspot.com/99960043/

R=axwalk

120. By Martin Packman on 2014-05-01

[r=gz] tools/secgroup-delete-all: Change test package

Change tests to be in package main rather than main_test,
which may work around an odd issue on the landing bot.

https://codereview.appspot.com/91010044/

R=axwalk, hduran-8

119. By Andrew Wilkins on 2014-04-23

[r=axwalk] http: close response body if unused

BinaryRequest calls may discard the response
without closing it. This was causing sockets
to be left open in juju-core/provider/openstack
tests, leading to test failures.

https://codereview.appspot.com/90540043/

118. By John A Meinel on 2014-03-07

[r=jameinel],[bug=1226996] panic if we get bad requests

It turns out that if you don't supply CIDR or GroupId Openstack just
sets CIDR to 0.0.0.0/0. We don't want to rely on that behavior, so
this just changes the goose test double to panic if it got that
situation.

This can't land until we land my updated Juju branch (or the test
suite will appropriately fail with panic().)

https://codereview.appspot.com/13781043/

117. By Dave Cheney on 2014-02-06

[r=dave-cheney] Make test pass on gccgo 4.8

gccgo 4.8 and 4.9 have a different view on the number of callers on the call stack.

Attempt to detect the correct value automatically.