lp://staging/goose
- Get this branch:
- bzr branch lp://staging/goose
Branch merges
- Juju Engineering: Pending requested
-
Diff: 2679 lines (+931/-386)32 files modifiedclient/client.go (+2/-0)
client/client_test.go (+5/-3)
client/live_test.go (+5/-5)
client/local_test.go (+10/-2)
goose.go (+3/-0)
http/client.go (+1/-0)
http/client_test.go (+51/-7)
identity/identity.go (+9/-3)
identity/identity_test.go (+51/-0)
identity/keypair.go (+41/-0)
identity/keystone.go (+89/-0)
identity/local_test.go (+22/-1)
identity/userpass.go (+1/-75)
nova/json.go (+167/-66)
nova/json_test.go (+1/-1)
nova/local_test.go (+7/-5)
nova/nova.go (+19/-24)
nova/nova_test.go (+2/-2)
swift/local_test.go (+2/-1)
testservices/identityservice/identityservice.go (+1/-0)
testservices/identityservice/keypair.go (+123/-0)
testservices/identityservice/keypair_test.go (+130/-0)
testservices/identityservice/legacy.go (+4/-0)
testservices/identityservice/userpass.go (+5/-3)
testservices/novaservice/service.go (+38/-38)
testservices/novaservice/service_http.go (+12/-35)
testservices/novaservice/service_http_test.go (+34/-49)
testservices/novaservice/service_test.go (+61/-61)
testservices/openstackservice/openstack.go (+27/-3)
tools/secgroup-delete-all/main_test.go (+2/-2)
version.go (+3/-0)
version_test.go (+3/-0)
Branch information
Recent revisions
- 128. By Dave Cheney
-
[r=dave-cheney],[bug=1365480] testservices/hook: fix gccgo build failure
Try to make the detection of the location in the raw stack trace where the method name is mentioned smarter.
Fixes build errors on ppc
- 127. By Dave Cheney
-
[r=dave-cheney],[bug=1336634] testing: fix data race in swift mock
- 126. By Ian Booth
-
[r=wallyworld],[bug=1247500] Fix unmarshalling of nil strings
In some nova structs sent and received over the
wire, serialised as json, there are id attributes
which can be string or int. We have custom marshalling
to handle that, but where the attributes were string
pointers, we were always unmarshalling as "" if the
value was nil. This broke things like floating ip
address usage. - 125. By Andrew Wilkins
-
[r=gz] Add support for Availability Zones
- Added ListAvailabilit
yZones to Nova client
- Added AvailabilityZone field to RunServerOpts
- Added AvailabilityZone field to ServerDetail
- Updated nova test-service to support all of the aboveAvailability zones are an OpenStack extension,
so I've made it so that ListAvailabilityZones will
ignore any 404 to the os-availability-zone URL. https:/
/codereview. appspot. com/103900045/ R=gz
- 124. By Dave Cheney
-
[r=dave-cheney] goose: fix vet errors
* fix several printf errors
* address unreachable code warnings. Rewrote branches to avoid unreachable code while being compatible with Go 1.0 - 123. By Kevin McDermott
-
[r=jameinel],[bug=1314366] This is a fix for this, basically, this code...
http/client.go
func (c *Client) sendRequest(method, URL string, reqReader io.Reader, length int, headers http.Header, expectedStatus []int, logger *log.Logger) (*http.Response, error) {
originally, only returned the body of the response, which meant there was no scope for getting the headers.
Coupled with this code from swift/swift.go
-func (c *Client) HeadObject(
containerName, objectName string) (headers http.Header, err error) the fact that it's creating headers here, masks the fact that they're not originating in the request.
I implemented HEAD in the fake server, mainly because it's the quickest way to test the fix, we don't necessarily need HEAD, but we wanted to proxy the headers returned by the Swift request to downstream clients (specifically ETag / cache-control headers).
- 122. By Horacio Durán
-
[r=hduran-8] Added json encoded for ServerErrors
added jsonEncode function to novaservice that
tries to convert the given error into a
ServerError and call its AsJSON method or
wrap the given error into a 500 ServerError
which will contain the original error message.https:/
/codereview. appspot. com/97870044/ R=gz
- 121. By Horacio Durán
-
[r=gz] Added proper errortype in testservices.
Added an error type for testservers that
contains a message and an error code.
Switched novaservice to use new error type.https:/
/codereview. appspot. com/99960043/ R=axwalk
- 120. By Martin Packman
-
[r=gz] tools/secgroup-
delete- all: Change test package Change tests to be in package main rather than main_test,
which may work around an odd issue on the landing bot.https:/
/codereview. appspot. com/91010044/ R=axwalk, hduran-8
- 119. By Andrew Wilkins
-
[r=axwalk] http: close response body if unused
BinaryRequest calls may discard the response
without closing it. This was causing sockets
to be left open in juju-core/provider/ openstack
tests, leading to test failures.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)