Code review comment for lp://staging/~waigani/juju-core/validate-environ-config

Please take a look.

https://codereview.appspot.com/62400043/diff/10001/environs/config.go
File environs/config.go (right):

https://codereview.appspot.com/62400043/diff/10001/environs/config.go#newcode267
environs/config.go:267: func ValidateConfig(oldConfig *config.Config,
args map[string]interface{}) (newProviderConfig *config.Config, err
error) {
On 2014/02/13 08:59:42, axw wrote:
> This doesn't look quite right to me. I think it should just have the
same
> signature as EnvironProvider.Validate.

Changed func name after discussing with Ian.

https://codereview.appspot.com/62400043/diff/10001/environs/config.go#newcode273
environs/config.go:273: env, err := New(oldConfig)
On 2014/02/13 08:59:42, axw wrote:
> This is way overkill for getting a provider. Instead, just get the
provider type
> from the config and use environs.Provider().

Done.

https://codereview.appspot.com/62400043/