Merge lp://staging/~vthompson/music-app/change-header-in-now-playing-queue into lp://staging/music-app/remix
Status: | Work in progress |
---|---|
Proposed branch: | lp://staging/~vthompson/music-app/change-header-in-now-playing-queue |
Merge into: | lp://staging/music-app/remix |
Diff against target: |
36 lines (+13/-2) 2 files modified
MusicNowPlaying.qml (+11/-0) music-app.qml (+2/-2) |
To merge this branch: | bzr merge lp://staging/~vthompson/music-app/change-header-in-now-playing-queue |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Music App Developers | Pending | ||
Review via email: mp+248076@code.staging.launchpad.net |
Commit message
* Change header color when in Now Playing or Queue to black.
Description of the change
* Change header color when in Now Playing or Queue to black.
After using the app with the newer full-cover Now Playing view, it's gotten a bit odd to have a grey header in this view, and in the Queue. I had played with changing the header to black earlier, but I think I dropped the attempt because it didn't seem to perform well. Or maybe the overflow action drawer wasn't conforming to the color change. Either way, it seems to work OK now.
Additionally, this will fit in nicely when the bottom edge capability arrives.
This will need some design review.
Unmerged revisions
- 821. By Victor Thompson
-
* Change header color when in Now Playing or Queue to black.
PASSED: Continuous integration, rev:821 91.189. 93.70:8080/ job/music- app-ci/ 1268/ 91.189. 93.70:8080/ job/generic- mediumtests- vivid/897 91.189. 93.70:8080/ job/generic- mediumtests- vivid/897/ artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/music- app-vivid- amd64-ci/ 120
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-ci/ 1268/rebuild
http://