Ubuntu CI Engine

Merge lp://staging/~vila/uci-engine/stores-with-path into lp://staging/uci-engine

  1. stores-with-path
  2. Merge into trunk
Proposed by Vincent Ladeuil
Status: Needs review
Proposed branch: lp://staging/~vila/uci-engine/stores-with-path
Merge into: lp://staging/uci-engine
Diff against target: 65 lines (+2/-25)
3 files modified
britney_proxy/britney/process_results.py (+1/-5)
ci-utils/ci_utils/data_store.py (+1/-2)
ci-utils/ci_utils/tests/test_data_store.py (+0/-18)
To merge this branch: bzr merge lp://staging/~vila/uci-engine/stores-with-path
Reviewer Review Type Date Requested Status
Evan (community) Needs Information
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+241960@code.staging.launchpad.net

Commit message

Allow data stores to use full paths

Description of the change

Allowing more than basename for artifacts became simpler since we removed 'cli' which was the only code relying on the data store to shorten the paths. The other users handle that themselves.

I've kept the BritneyDataStore as-is for now so we don't lose track of the associated FIXME.

This is a pre-requisite to store test runner artifacts under <package>/<arch> which is a pre-requisite for storing multiple test runs inside the same swift container and also needed for uci-britney.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:897
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1717/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1717/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~vila/uci-engine/stores-with-path updated
898. By Vincent Ladeuil

Fix pyflakes issue.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:898
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1718/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1718/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Evan (ev) :
review: Needs Information
Reply
Revision history for this message
Vincent Ladeuil (vila) wrote :

> Why keep this at all?

From the cover letter: I've kept the BritneyDataStore as-is for now so we don't lose track of the associated FIXME.

And keep the MP small.

The BritneyDataStore will need to be revisited so I prefer to keep the existing references in place instead of replacing them with DataStore. They are equivalent right now but they are not used in the same way (the engine use a swift container for a single ticket, britney uses a swift container for all test results), so I expect this difference to be carried by BritneyDataStore when the time comes.

Reply

Unmerged revisions

898. By Vincent Ladeuil

Fix pyflakes issue.

897. By Vincent Ladeuil

Now that the 'cli' is gone, nobody requires artifact paths to be reduced to their basename. The corresponding tests are not required anymore either.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches