Code review comment for lp://staging/~vila/ubuntu-ci-services-itself/ts-setup
Revision history for this message
| Chris Johnston (cjohnston) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
On Tue, Feb 18, 2014 at 5:21 PM, Andy Doan <email address hidden>wrote:
> i don't know if we should totally scrap this. One cool idea from this
> branch was using settings.LOCAL_APPS instead of hard-coding the apps in
> setup.py. how it was done (by changing manage.py) isn't right. I'd say we
> can iterate off this, or just do a new MP with that simple change.
>
I would be ok with an MP using settings.
I'm still -1 for the MP as it stands.