Code review comment for lp://staging/~vila/ubuntu-ci-services-itself/ts-setup

Revision history for this message
Vincent Ladeuil (vila) wrote :

> We aren't changing django, south, or tastypie during our development. Why
> would we want to run their tests?

To catch regressions ? Why do you think the django devs did that behavior
the default one ?

>
> I don't think anyone is opposed to having *a* way to run all of the tests for
> the entire ci engine.
>
> I personally do not want to run all the tests very often but when I'm working
> on a component I want an easy way to test just that component I'm working on,
> perhaps even just one small piece of that component. I don't want to have to
> run:
>
> ../run-tests <some obscure incantation to get me down to a single testcase
> or suite>
>
> which is ultimately calling:
>
> ./manage.py test <app>.TestCaseClass.test
>

As it happens that obscure incantation is:

  ./run-tests <app>.TestCaseClass.test

what's obscure with that ?

As an added bonus, if your test has a unique method name you can even just
do:

  ./run-tests test_unique_name

or whatever regexp that captures your need without having to switch to a
different syntax when you work on a different component.

> It looks to me like the changes on L21-24 remove the ability to specify tests
> from setup.py as well. What is the reasoning behind this?

That setup.py calls manage.py ?

>
> As for changing manage.py, that file is generated by django in the process of
> setting up a project. I avoid changing it.

It has already been changed.

> Lastly, I find your commit message offensive and condescending.

Then I'm all ears about why a technical change that address your needs raise
such reactions ?

'obscure incantation' is also offensive when I'm offering a simpler
aproach. I can live with that as long as progress is made.

« Back to merge proposal