Code review comment for lp://staging/~vila/ubuntu-ci-services-itself/ts-setup
Revision history for this message
| Joe Talbott (joetalbott) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
We aren't changing django, south, or tastypie during our development. Why would we want to run their tests?
I don't think anyone is opposed to having *a* way to run all of the tests for the entire ci engine.
I personally do not want to run all the tests very often but when I'm working on a component I want an easy way to test just that component I'm working on, perhaps even just one small piece of that component. I don't want to have to run:
../run-tests <some obscure incantation to get me down to a single testcase or suite>
which is ultimately calling:
./manage.py test <app>.TestCaseC
It looks to me like the changes on L21-24 remove the ability to specify tests from setup.py as well. What is the reasoning behind this?
As for changing manage.py, that file is generated by django in the process of setting up a project. I avoid changing it.
Lastly, I find your commit message offensive and condescending.