Code review comment for lp://staging/~vila/ubuntu-ci-services-itself/secgroups

Revision history for this message
Francis Ginther (fginther) wrote :

> I'm taking a look at leon with a use case that I have juju deployed nodes that
> are unrelated to the ucsi nodes and they shouldn't be touched. I'll admit I'm
> more than a bit nervous about automatically removing security groups, but
> realize that our options are limited when it comes to automating. Just need to
> do some deeper review here.
>
> Also the change to make jenkins work again is necessary regardless of leon,
> let's get it merged: https://code.launchpad.net/~cjohnston/ubuntu-ci-
> services-itself/fix-bzr-error/+merge/207218

Wait, on closer inspection, leon isn't automatically executed. I may be jumping to conclusions a bit on this.

« Back to merge proposal