Code review comment for lp://staging/~vila/ubuntu-ci-services-itself/secgroups

Revision history for this message
Paul Larson (pwlars) wrote :

> Does firewall-mode: global not work as recommended [1] and by ev:
>
> 2014-02-14 11:46:49 ev cjohnston: I think we're safe to enable
> `firewall-mode: global` here for now
> 2014-02-14 11:47:03 ev it's okay if these things are all listening on
> 8080
>
> This would remove the need for the script and for a 5 line description of what
> leon means.
>
> [1] https://bugs.launchpad.net/juju/+bug/1027641/comments/7
+1 on the name change. I'm sad to say that my parser ignored the comments and I spent a few (pre-coffee) minutes staring at "Note that nova will fail to delete a security group if it's still in use which offers a *little* protection against Leon's misuse." this morning wonder who the hell Leon is and why he's misusing our stuff. :)

That being said, have you actually tried the `firewall-mode: global` option? Admittedly, it's been a while since I tried it, and I did so on hpcloud where there were (and still are) other problems, but it didn't work well for me at the time. If it works, then I like that approach better.

« Back to merge proposal