Code review comment for lp://staging/~vila/ols-store-tests/ols-run-tests

Revision history for this message
Vincent Ladeuil (vila) wrote :

> What if we made this part of the setUp and tearDown process and put it in the base TestCase.

Take two.

setUp() is too late, this has to happen in __init__.

Last revision does that.

I still think it's a bit too magic (I have a gut feeling this may break in an obscure way in edge cases (parametrized tests for example)) and prefer to decorate the tests that really needs that but let's see how this goes.

« Back to merge proposal