Code review comment for lp://staging/~vila/bzr/308472-info-version-smart-server

Revision history for this message
Andrew Bennetts (spiv) wrote :

> - it should not assume repositories have a _client attribute. I expect that

In fact, I see from my review in BundleBuggy it's worse than that, this is actually reporting the client's version, not the server's! See <https://lists.ubuntu.com/archives/bazaar/2009q3/060332.html>

Perhaps a good change would be to look for this header in the response to the 'Repository.gather_stats' RPC, although that doesn't fit neatly in the API, and won't help when there's no remote repository.

Perhaps the right time to fix this is when we add a no-VFS way to do info via smart server? (That way, even if the server is too old to support the new no-VFS verb for info we still have an obvious point to check for the 'Software version' header in the error response.)

review: Needs Resubmitting

« Back to merge proposal