Code review comment for lp://staging/~victored/beat-box/view-restructuring

Daniel, I think that's a good idea. Not sure about where to put that button though.

In regard to the options... well, it's a tough decision.

1) Showing the filter for all the views. This is exactly how Zune and Banshee do it. The main advantage of this setup is faster browsing when using the AlbumView with very large collections. Another advantage is that I wouldn't have to fix Bug #959885 :)

2) Sounds cool too. Implies no extra changes apart from adding the button. Disadvantage: Bug #959885 still applies here.

Maybe we could play around with the idea. We're already used to (2) since it behaves exactly like the current implementation. I propose implementing (1), testing for a while and then making a decision. Making the required modifications wouldn't take long :)

What do you think?

> Hey Victor, Do you think it would be appropriate to move the filter into it's
> own button? Keep in mind that this would imply that either:
> 1. you can use the filter and album view at the same time, in which case it
> wouldn't make sense to show the album column. or
> 2. filter button is made insensitive when you switch to album view.
>
> Also, I can confirm Matthew's back button bug. I actually filed a report about
> it thinking it was caused by a song I had where the artists name had a "." in
> it :P