Merge lp://staging/~veger/ubuntu/precise/pbuilder/fix-for-933339-v2 into lp://staging/ubuntu/precise/pbuilder

Proposed by Maarten Bezemer
Status: Merged
Merged at revision: 50
Proposed branch: lp://staging/~veger/ubuntu/precise/pbuilder/fix-for-933339-v2
Merge into: lp://staging/ubuntu/precise/pbuilder
Diff against target: 102 lines (+69/-11)
2 files modified
bash_completion.d/pbuilder (+63/-11)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp://staging/~veger/ubuntu/precise/pbuilder/fix-for-933339-v2
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Approve
Ubuntu branches Pending
Review via email: mp+93748@code.staging.launchpad.net

Description of the change

This change should add complete support for auto completion of the pbuilder command.

It supports:
- all available command and flags
- filename/directory completion for certain flags
- sudo in front of the command
- filename completion for the dsc file (only available for the build command)

Note: It is similar to/inspired on the dpkg script. The script tries to use the build in/available /etc/bash_completion functions for robustness/flexibility

To post a comment you must log in.
Revision history for this message
Luke Yelavich (themuso) wrote :

Thanks for your work, you jmight want to consider sending these improvements to Debian, as this is a change that seems useful for Debian as well.

review: Approve
Revision history for this message
Maarten Bezemer (veger) wrote :

I will send the patch to them as well

Revision history for this message
Maarten Bezemer (veger) wrote :

While preparing the patch for Debian, I noticed that the changelog entry is wrong. As it reads:
  (Closes: #933339)
instead of
  (LP: #933339)

It is too late to change it, I suppose? Maybe just change it in the repository, so it will be fixed for a next release?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches