Mir

Code review comment for lp://staging/~vanvugt/mir/remove-input-resampling-standalone

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

No, consumeBatches should always be true now. We don't batch anything and want clients to receive all events immediately.

It was just our tests were overly simplistic and not able to consume wake notifications when they dispatch(), leaving the fd readable indefinitely. So it was just a problem with the tests. But instead of modifying the tests too much I have reworked the semaphore logic to deal with the simplistic test expectations so that dispatch() can also drain wake()'s.

« Back to merge proposal