Compiz

Merge lp://staging/~vanvugt/compiz/fix-1009338 into lp://staging/compiz/0.9.8

  1. fix-1009338
  2. Merge into 0.9.8
Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3245
Merged at revision: 3246
Proposed branch: lp://staging/~vanvugt/compiz/fix-1009338
Merge into: lp://staging/compiz/0.9.8
Diff against target: 45 lines (+6/-4)
2 files modified
plugins/composite/composite.xml.in (+1/-1)
plugins/composite/src/screen.cpp (+5/-3)
To merge this branch: bzr merge lp://staging/~vanvugt/compiz/fix-1009338
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
Review via email: mp+108888@code.staging.launchpad.net

Description of the change

Fall back to a refresh rate that is more likely to look correct; 60Hz.
(LP: #1009338)

The fallback is still only used if sync-to-vblank is not available (disabled
in the driver) AND if xrandr doesn't provide a refresh rate.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Approve, please change

+#define FALLBACK_REFRESH_RATE 60 /* if all else fails */

To

static const unsigned int FALLBACK_REFRESH_RATE = 60

review: Approve
lp://staging/~vanvugt/compiz/fix-1009338 updated
3246. By Daniel van Vugt

Stylistic request to avoid macros.

Though doing so does have the added benefit of generating a symbol you can
see in a debugger.

Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches