lp://staging/~vanvugt/compiz/fix-1009338

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/compiz/0.9.8 at revision 3246

Sam Spilsbury: Approve on 2012-06-07

Diff: 45 lines (+6/-4)

2 files modified

plugins/composite/composite.xml.in (+1/-1)
plugins/composite/src/screen.cpp (+5/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1009338: composite refresh rate falls back to 50Hz, which is wrong in most cases

Low

Fix Released

Link a bug report

Related blueprints

3246. By Daniel van Vugt on 2012-06-06

Stylistic request to avoid macros.

Though doing so does have the added benefit of generating a symbol you can
see in a debugger.

3245. By Daniel van Vugt on 2012-06-06

Fall back to a refresh rate that is more likely to look correct; 60Hz.
(LP: #1009338)

The fallback is still only used if sync-to-vblank is not available (disabled
in the driver) AND if xrandr doesn't provide a refresh rate.

3244. By Sam Spilsbury on 2012-06-06

Adds some tests for the pixmap rebinding code ... which also means some
refactoring was done.

3243. By Sam Spilsbury on 2012-06-06

Avoid needless STL operations leading to expensive heap operations.
(LP: #1006335)

3242. By Sam Spilsbury on 2012-06-06

Fix a typo that was causing LP: #1002606 (widthIncBorders/heightIncBorders)

3241. By Sam Spilsbury on 2012-06-06

Check if the window is decorated before trying to change its event window
states (which won't exist if not decorated) (LP: #1007754)

3240. By Daniel van Vugt on 2012-06-05

Revert the previous commit. I can see a potential race that might lead to
damage artifacts.

3239. By Daniel van Vugt on 2012-06-05

Use the XDamage extension more efficiently (the way it was designed to be
used). This dramatically reduces CPU usage, reduces wakeups, and increases
frame rates. It also solves at least one observed performance bug
(LP: #1007299) and probably several more.

3238. By Daniel van Vugt on 2012-06-05

Fix up a few issues thumper pointed out in the fixes for LP: #1005569.

  * Use else instead of unconditional reset (makes the first call faster,
    but all others slower, negligibly)
  * Don't mask locals by reusing the same name
  * Remember to reset arg[7] for XkbStateNotify
  * Check for NULL strings. Don't dereference them, just treat as empty.

3237. By Daniel van Vugt on 2012-05-31

Improve the fix for LP: #1005569:
Calling CompOption::setName should not implicitly construct a new string
object every time, when the name is not changing.

This is also an alternative fix to the previous commit, but both together
don't hurt either.