QtMir

Merge lp://staging/~unity-team/qtmir/1541388.close-resumable into lp://staging/qtmir

  1. 1541388.close-resumable
  2. Merge into trunk
Proposed by Michał Sawicz
Status: Rejected
Rejected by: Gerry Boland
Proposed branch: lp://staging/~unity-team/qtmir/1541388.close-resumable
Merge into: lp://staging/qtmir
Prerequisite: lp://staging/~dandrader/qtmir/removeUselessClass
Diff against target: 56 lines (+38/-0)
2 files modified
src/modules/Unity/Application/application.cpp (+3/-0)
tests/modules/ApplicationManager/application_manager_test.cpp (+35/-0)
To merge this branch: bzr merge lp://staging/~unity-team/qtmir/1541388.close-resumable
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Unity8 CI Bot (community) continuous-integration Needs Fixing
Michael Zanetti Pending
Review via email: mp+284968@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-02-03.

Commit message

Added fix and test for closing app during the StoppedResumable state.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:439
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/57/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/57/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:442
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/58/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/58/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote : Posted in a previous version of this proposal

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

waiting. But tests are passing here.

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:442
http://jenkins.qa.ubuntu.com/job/qtmir-ci/680/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/374
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/376
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/376/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/256
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/411/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/413/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/256/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/680/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:444
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/59/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/59/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:444
http://jenkins.qa.ubuntu.com/job/qtmir-ci/681/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-amd64-ci/375
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/377
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-armhf-ci/377/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-vivid-i386-ci/257
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-amd64-ci/412/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-armhf-ci/414/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtmir-wily-i386-ci/257/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/681/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

This fix landed in rev 439 already.

Unmerged revisions

444. By Michał Sawicz

Adapt to new TaskController

443. By Michał Sawicz

Merge lp:~dandrader/qtmir/removeUselessClass

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches